Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add congruences of subtypes and sets/finsets. #19514

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat: add congruences of subtypes and sets/finsets. #19514

wants to merge 6 commits into from
+60 −0

Conversation

qawbecrdtey
Copy link
Collaborator

A congruence about subtypes and sets/finsets.

Related zulip thread

Open in Gitpod

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 26, 2024 •
edited
Loading

PR summary 192e81ddbc

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ finsetSubtypeCongr
+ setSubtypeCongr

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Nov 26, 2024
@qawbecrdtey qawbecrdtey changed the title Added congruence about subtypes. feat: add congruences between subtypes and sets/finsets. Nov 26, 2024
@qawbecrdtey qawbecrdtey changed the title feat: add congruences between subtypes and sets/finsets. feat: add congruences of subtypes and sets/finsets. Nov 26, 2024
kim-em
kim-em reviewed Nov 26, 2024
View reviewed changes
Mathlib/Data/Set/Basic.lean Outdated Show resolved Hide resolved
@kim-em kim-em added the awaiting-author A reviewer has asked the author a question or requested changes label Nov 26, 2024
@qawbecrdtey qawbecrdtey removed the awaiting-author A reviewer has asked the author a question or requested changes label Nov 27, 2024
b-mehta
b-mehta reviewed Nov 27, 2024
View reviewed changes
Mathlib/Data/Finset/Image.lean Outdated Show resolved Hide resolved
Mathlib/Data/Finset/Image.lean Show resolved Hide resolved
Mathlib/Data/Finset/Image.lean Outdated Show resolved Hide resolved
qawbecrdtey and others added 2 commits November 29, 2024 13:32
@qawbecrdtey
Added comments on generated lemmas.
a3c1ee0
@qawbecrdtey @github-actions
Update Mathlib/Data/Finset/Image.lean
192e81d 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-mehta b-mehta b-mehta left review comments

@kim-em kim-em Awaiting requested review from kim-em

Assignees
No one assigned
Labels
t-data Data (lists, quotients, numbers, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qawbecrdtey @kim-em @b-mehta